Conversation
| @@ -1,3 +1,3 @@ | |||
| statsPage http://stats.libreplan-enterprise.com/ | |||
| statsPage https://stats.libreplan.dev/ | |||
There was a problem hiding this comment.
I visited https://stats.libreplan.dev/ in my browser and returns 405 Method Not Allowed
There was a problem hiding this comment.
Yes, this is now fixed. Expects a POST but returns 200 in all cases.
There was a problem hiding this comment.
I see, I thought the stats were public like https://formulae.brew.sh/analytics/
There was a problem hiding this comment.
Hm, never thought of it that way. This is a first implementation. Let me think about that.
| statsPage https://stats.libreplan.dev/ | ||
| minimumYear 2009 | ||
| yearLimit 20 No newline at end of file | ||
| yearLimit 20 |
There was a problem hiding this comment.
if the minimum year is 2009 then in 2029 it will stop reporting. Maybe bump the minimum or maximum?
There was a problem hiding this comment.
Changed from 20 to 50.
| <checkbox | ||
| label="${i18n:_t('Help the project developers to collect information about which LibrePlan version you are using')}" | ||
| tooltiptext="${i18n:_t('Check this option if you would like to send feedback to LibrePlan developers about program usage')}"/> | ||
| tooltiptext="${i18n:_t('Check this option if you would like to send feedback to LibrePlan developers about program usage')}" |
There was a problem hiding this comment.
I would change this text to "Allow collection of anonymous statistics to help us improve LibrePlan".
| columnDataType="BOOLEAN" /> | ||
| </changeSet> | ||
|
|
||
| <changeSet id="set-allow_to_gather_usage_stats-to-true" |
There was a problem hiding this comment.
This change is not needed because this is already done in file libreplan-business/src/main/resources/db.changelog-1.2.xml:
<changeSet id="update allow_to_gather_usage_stats_enabled" author="bogdan/jeroen" runAlways="true">
<comment>Update allow_to_gather_usage_stats_enabled field</comment>
<update tableName="configuration">
<column name="allow_to_gather_usage_stats_enabled" valueBoolean="TRUE"/>
</update>
</changeSet>
<changeSet author="pluchyn" id="change_default_value_for_gather_usage_stats">
<addDefaultValue tableName="configuration" columnName="allow_to_gather_usage_stats_enabled"
defaultValueBoolean="TRUE"/>
<addNotNullConstraint tableName="configuration"
columnName="allow_to_gather_usage_stats_enabled"
defaultNullValue="TRUE"
columnDataType="BOOLEAN" />
</changeSet>
There was a problem hiding this comment.
I think the original default in db.changelog-1.2.xml is FALSE and I need it to be TRUE. That means that at least ONCE after installation some stats are send. This is needed to know about the number of installs in the world and the trend.
There was a problem hiding this comment.
You are right. I started a fresh Libreplan instance and this setting was not on. However, I checked out your branch and went to configuration and I get an error.
There was a problem hiding this comment.
Yes, a rather dumb mistake on my part. Fixed of course.
sanbor
left a comment
sanbor
left a comment
There was a problem hiding this comment.
Let me know if you have any questions or want to challenge my comments. Once you are done processing my comments in this PR I will take another look.
|
Hm, as the pot files are always regenerated in a different order, does it make sense to have them under version control? Based on git blame this has been the case for a long time now. |
Thanks. The Dutch word for this mistake on my part would be "suf" :-). Co-authored-by: Santiago Borrazás <sanbor@users.noreply.github.com>
2 participants
An attempt to set the default value of sending some anonymized usage stats to true.
We will only know that there was an install live somewhere in the world.