OpenCV 3 constants disambiguation. More robust triangulation with cv2…

[royshil]

….undistortPoints. bugfix in settings.

This presumably has more accurate results from using OpenCV's undistortPoints which also takes into account the distortion of the camera lens into the 3D reconstruction.

I also fixed the issue with OpenCV3 where the constant names have changed.
It is now compatible with OpenCV python binding.

Great project!

[royshil]

This now is rebased on top of release/2.0 which seems to be the active thread of development.
Let me know if I should undo this, Thanks!

[bubnikv]

@royshil Is there any distortion calibration in the released Horus? Or did you add a camera distortion calibration through this pull request? How much does it improve the scanning quality? Do you have any idea whether your work will be merged and when? Thanks.

[royshil]

@bubnikv the current calibration (in the "advanced mode") does calculate the dist coeffs but they are not used anywhere in the triangulation and reconstruction.
i havn't noticed a very big difference just by eyeballing it.
but it should anyway be included if accurate results are expected.

i've no idea if this will ever be merged. I suspect the project is dormant.

[bubnikv]

Thanks for the response, Roy. If the project is dormant and the owner does not respond to pull request, then I suppose we should just fork it. Maybe the other ciclop kit producer, the CowTech could sponsor the effort. Vojtech

…

On Fri, Apr 14, 2017 at 9:10 PM, Roy Shilkrot ***@***.***> wrote: @bubnikv <https://github.com/bubnikv> the current calibration (in the "advanced mode") does calculate the dist coeffs but they are not used anywhere in the triangulation and reconstruction. i havn't noticed a very big difference just by eyeballing it. but it should anyway be included if accurate results are expected. i've no idea if this will ever be merged. I suspect the project is dormant. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/bqlabs/horus/pull/106#issuecomment-294216831>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFj5I5BTTGJULt36T0OA1XvPCru33r6Yks5rv8S5gaJpZM4MvyAZ> .