Modification in verbosity and calibration#43
Open
javivi001 wants to merge 11 commits intoLibreScanner:developfrom
Open
Modification in verbosity and calibration#43javivi001 wants to merge 11 commits intoLibreScanner:developfrom
javivi001 wants to merge 11 commits intoLibreScanner:developfrom
Conversation
modified: src/horus/engine/calibration.py modified: src/horus/engine/scan.py Updated verbosity and calibration use of pattern
modified: README.md new file: doc/images/synology.png new file: res/images/pattern-position-center.jpg modified: src/horus/gui/workbench/calibration/pages.py Added some pictures in Readme and Calibration.
modified: res/images/pattern-position-center.jpg
Some minor edit.
update to last changes
Changes to be committed: new file: syno-horus.sh
Your branch is up-to-date with 'origin/develop'. Changes to be committed: modified: README.md new file: doc/installation/synology.md Update instalation method on Synology
Contributor
|
Hi! We have made a lots of changes in Horus, some similar to yours, now its difficult to merge this code changes. Also I have improved autocheck and calibration algorithms for new version 0.2 beta. I also observed that you have added Synology support. Can you reconfigure your pull request to include only files related with Synology? Thanks! |
Jesus89
force-pushed
the
develop
branch
5 times, most recently
from
bdd6feb to
cee6558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated how the pattern is used in calibration to make posible repeat the calibration of laser and extrinsics.
Added more verbosity in calibration and scan files.