This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Fixing compatibility with python3#28
Open
UnknownProgrammer wants to merge 2 commits intoLightTable:masterfrom
Open
Fixing compatibility with python3#28UnknownProgrammer wants to merge 2 commits intoLightTable:masterfrom
UnknownProgrammer wants to merge 2 commits intoLightTable:masterfrom
Conversation
Added try-except because python3 has no unicode class.
|
This could probably just be in a try-except block (i.e. not mention |
|
This seems to be related to #24. @UnknownProgrammer – how 'bout this: |
|
@kenny-evitt I think that encode is actually incorrect here. it should decode, otherwise if you pass bytes it becomes u"b'string'" which I don't think is not what you want? |
|
@hayd I have no idea what that code does; I just know that it currently calls |
Author
|
@kenny-evitt That's nicer, I just wanted it to work with python 3 without removing someone's work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added try-except because python3 has no unicode class.