This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Fixing some bugs with ipython creation in python3 and some issues with creating namespaces#8
Open
natelust wants to merge 1 commit intoLightTable:masterfrom
natelust:master
Open
Fixing some bugs with ipython creation in python3 and some issues with creating namespaces#8natelust wants to merge 1 commit intoLightTable:masterfrom natelust:master
natelust wants to merge 1 commit intoLightTable:masterfrom
natelust:master
Conversation
…ed a namespace issue being created and importing in lttools in the toModule function creating a blank namespace with the file name to connect to the popen ipython process. This way the file does not have to be run and imported if it is not fully complete or there are bugs, which would cause the import to fail.
There was a problem hiding this comment.
I think here it would be much easier to use sys.version_info[0] (that's already an integer)
Author
There was a problem hiding this comment.
You are right, that was just something quick and dirty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...a namespace issue being created and importing in lttools in the toModule function creating a blank namespace with the file name to connect to the popen ipython process. This way the file does not have to be run and imported if it is not fully complete or there are bugs, which would cause the import to fail.