feat(cli): unify resource deletion - #62
Merged
Merged
Conversation
justusschock
force-pushed
the
justus/unified-delete-cli
branch
from
July 30, 2026 11:59
e791a06 to
6dd10be
Compare
justusschock
marked this pull request as ready for review
July 30, 2026 15:57
justusschock
force-pushed
the
justus/unified-delete-cli
branch
from
July 30, 2026 15:59
9d4126e to
d468de0
Compare
justusschock
enabled auto-merge (squash)
July 30, 2026 17:20
tejapulagam
reviewed
Jul 30, 2026
tejapulagam
left a comment
Contributor
There was a problem hiding this comment.
Job / MMT / container / API key : currently delete automatically with no prompt; now this will prompt unless -y is included in the command so this might cause hangs in existing user scripts?
Member
Author
that's true, but at some point we need to make a breaking change if we want to unify this. |
ethanwharris
approved these changes
Jul 31, 2026
ethanwharris
left a comment
Member
There was a problem hiding this comment.
Code looks good, slight preference for y/N but nbd
k223kim
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
[y/N]confirmation, supports-y/--yes, and prints<Resource> deleted--jsonCommands and output
Enter accepts the safe default and aborts deletion; enter
yto confirm.Studio
Job
Multi-machine job
Deployment
Container
API key
Sandbox
Sandbox snapshot
Context overrides remain available where applicable:
--teamspacefor Studio, Job, MMT, Deployment, and Container;--orgfor API keys; and--api-keyfor Sandboxes and Snapshots.Why
Deletion commands had separate implementations and inconsistent arguments, confirmation behavior, flags, and success output. This gives every registered resource deletion command the same user-facing contract.