Fix cross-module dependency between MonitoringModule and UserModule#148
Merged
TaprootFreak merged 1 commit intoLightningDotSpace:developfrom Feb 14, 2026
Conversation
Danswar
reviewed
Feb 14, 2026
src/subdomains/user/user.module.ts
Outdated
| LightningWalletService, | ||
| UserTransactionService, | ||
| UserBoltcardService, | ||
| LightingWalletRepository, |
Collaborator
There was a problem hiding this comment.
I think accessing the repository directly is not a good practice, normally we access it the data through the services, in this case LightningWalletService to avoid consumer classes to have too much access over the database.
TaprootFreak
force-pushed
the
fix/monitoring-cross-module-dependency
branch
from
10518e2 to
31b4a89
Compare
Danswar
approved these changes
Feb 14, 2026
MonitoringModule was directly importing LightningWalletEntity and LightningWalletRepository from the user subdomain, bypassing module boundaries. Use forwardRef to properly declare the circular dependency between MonitoringModule and UserModule. Access balance data through LightningWalletService instead of the repository directly, keeping database access encapsulated in the service layer.
TaprootFreak
force-pushed
the
fix/monitoring-cross-module-dependency
branch
from
31b4a89 to
6d7657c
Compare
2 tasks
TaprootFreak
added a commit
that referenced
this pull request
Feb 14, 2026
MonitoringService and LightningWalletService have a circular dependency. PR #148 added forwardRef only on the MonitoringService side. The missing forwardRef on LightningWalletService caused the app to crash on startup (503).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MonitoringModulewas directly importingLightningWalletEntityandLightingWalletRepositoryfrom theusersubdomain, bypassing NestJS module boundariesMonitoringModuleandUserModuleinvisible to the DI systemforwardRefto properly declare the circular dependency and exportsLightingWalletRepositoryfromUserModuleTest plan
yarn lintpassesyarn buildpasses