feat(core): report scenario override outcomes - #6
Open
92Infinitus92 wants to merge 7 commits into
Open
Conversation
92Infinitus92
force-pushed
the
feat/scenario-override-outcomes
branch
from
August 17, 2026 08:37
bfb0481 to
291cabf
Compare
92Infinitus92
force-pushed
the
feat/scenario-override-outcomes
branch
from
August 17, 2026 09:02
291cabf to
3601a68
Compare
There was a problem hiding this comment.
92Infinitus92 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR adds typed applied/skipped outcomes for scenario overrides and exposes outcome-aware registration, cancellation, and time travel through RPC and the Node SDK.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Sequence Diagram
sequenceDiagram participant Client participant RPC participant SVM participant Stage as Staged SVM participant Store as Account and Schedule Storage Client->>RPC: Register scenario or time travel RPC->>SVM: Materialize scheduled overrides SVM->>Stage: Apply override batch Stage-->>SVM: Typed applied/skipped outcomes SVM->>Store: Atomic account commit and schedule removal Store-->>SVM: Commit success SVM-->>RPC: Epoch context and outcomes RPC-->>Client: "RpcResponse<OverrideOutcome[]>"Reviews (9): Last reviewed commit: "fix(core): retry current-slot overrides ..." | Re-trigger Greptile