fix(executor): align single-thread lifecycle semantics - #101
Merged
Conversation
Make SingleThreadExecutor::wait() drain already accepted tasks even after shutdown starts, and make queue policy updates no-op after shutdown in native and Emscripten implementations. Document the dedicated executor lifecycle contract and add a regression test for wait during concurrent shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SingleThreadExecutor::wait()drain accepted tasks even after shutdown startsSingleThreadExecutor::set_queue_policy()a no-op after shutdown on native and single-threaded Emscripten buildswait()does not return early during concurrent shutdownTest Plan
git diff --check -- . ':!external/zlib'g++ -std=c++17 -Iinclude/logit_cpp -Iexternal/time-shield-cpp/include tests/single_thread_executor_test.cpp -o tmp/codex_verify/single_thread_executor_test.exe+ rung++ -std=c++17 -Iinclude/logit_cpp -Iexternal/time-shield-cpp/include tests/dedicated_executor_shutdown_test.cpp -o tmp/codex_verify/dedicated_executor_shutdown_test.exe+ rung++ -std=c++17 -Iinclude/logit_cpp -Iexternal/time-shield-cpp/include tests/console_logger_dedicated_config_test.cpp -o tmp/codex_verify/console_logger_dedicated_config_test.exe+ rung++ -std=c++17 -Iinclude/logit_cpp -Iexternal/time-shield-cpp/include tests/per_logger_mixed_mode_test.cpp -o tmp/codex_verify/per_logger_mixed_mode_test.exe+ runNotes
em++is unavailable, so CI should cover it.