fix(utils): inline path helpers for odr safety - #80
Closed
LimiNode wants to merge 2 commits into
Closed
Conversation
Mark path utility functions and argument parser helper inline to avoid ODR violations when the headers are included in multiple translation units. Add a dual-standard (C++11/C++17) two-TU smoke build to exercise the public API and catch regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logit/utils/path_utils.hppas inline to avoid duplicate symbols across translation unitsis_closing_templatehelper inlogit/utils/argument_utils.hppTesting
cmake --build build --target logit_odr_cxx11 logit_odr_cxx17ctest --test-dir build --output-on-failure -R logit_odrhttps://chatgpt.com/codex/tasks/task_e_68ce4156cb74832cb0bc244253eaa4e7