Wait for spdlog sink to drain before completing tokens - #87
Merged
LimiNode merged 2 commits intoDec 4, 2025
Conversation
Ensure pending async messages drain before completing tokens to avoid recorder overcounts and incomplete latency capture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
LOGIT_BENCH_TOTAL=200 LOGIT_BENCH_WARMUP=20 LOGIT_BENCH_FILTER_LIB=spdlog LOGIT_BENCH_FILTER_ASYNC=1 LOGIT_BENCH_FILTER_SINK=file LOGIT_BENCH_FILTER_PRODUCERS=4 LOGIT_BENCH_FILTER_BYTES=40 ./build/logit_benchLOGIT_BENCH_TOTAL=200 LOGIT_BENCH_WARMUP=20 LOGIT_BENCH_FILTER_LIB=spdlog LOGIT_BENCH_FILTER_ASYNC=1 LOGIT_BENCH_FILTER_PRODUCERS=4 LOGIT_BENCH_FILTER_BYTES=40 ./build/logit_benchCodex Task