Conversation
- format_workspace now handles both Windows (\) and POSIX (/) paths regardless of host OS, via string normalization instead of PurePosixPath - Add 8 unit tests covering Windows, POSIX, trailing separators, empty, None, relative, and single-name inputs - Add GitHub Actions matrix: ubuntu/macos/windows x py3.10/3.13 - Add .gitattributes enforcing LF line endings across the repo Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Mechanical CRLF->LF conversion on files that were committed with CRLF under Windows' core.autocrlf. No content changes; diff is empty under `git diff --ignore-cr-at-eol`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Python 3.10's datetime.fromisoformat rejects ISO strings with a trailing "Z" (that was added in 3.11). cchat JSONL timestamps from Claude Code often include the "Z" suffix, so on 3.10 format_timestamp was silently returning em-dash for those values, which broke test_sort_newest_oldest and degraded `cchat list` output. Normalize "Z" to "+00:00" before parsing. Add a regression test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format_workspaceso the newWORKSPACEcolumn works on Windows (PurePosixPathdoesn't treat\as a separator). String normalization handles both\and/regardless of host OS, plus trailing separators, empty, andNone.tests/test_formatters.py::TestFormatWorkspace..github/workflows/ci.ymlmatrix:ubuntu/macos/windowsxpy3.10/3.13,fail-fast: false. Runsjust install && just check..gitattributesenforcing LF line endings across the repo (protects test fixtures and new contributions from CRLF drift on Windows).git diff --ignore-cr-at-eol.Why
After #1, the
WORKSPACEcolumn defaulted on forcchat listbut returned the full path string on Windows instead of the basename. Fixing that exposed a broader need: we want cchat to stay healthy on both Windows and macOS as it evolves, so CI is the enforcement mechanism going forward.Test plan
just checkpasses locally on Windows (pytest 412 passed; ruff clean; ty shows 3 pre-existing unresolved-import warnings for optionalfastapi/uvicorndeps, unchanged by this PR)just install && just check && cchat listrenders WORKSPACE column correctly