[codex] Harden pyc5 build flow and add CI gates#47
Merged
zhoubot merged 6 commits intoLinxISA:mainfrom Apr 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request transitions the repository to the pyc5 frontend surface, introducing updated contributor workflows, pre-commit hooks, and comprehensive documentation. Key technical changes include enhancing the JIT evaluator to support v5 cycle-aware and state signals, and refining StateSignal logic to ensure reads are rebased to the current logical occurrence, thereby preventing unnecessary balance registers. New system and unit tests have been added to validate CLI entrypoints and v5 semantics. Feedback highlights a missing rebase in the StateSignal indexer and suggests implementing reverse subtraction to remove a current JIT limitation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pycircuit.cli buildaccepts both supported entrypoint forms, resolves public probe targets correctly, invalidates stale JIT cache artifacts after frontend changes, and keepsStateSignalrecurrence reads on the current logical occurrenceDecision / Contract Impact
Root Cause
The timed-domain lane still had a few gaps relative to the current pyc5 contract:
domainlike a user JIT parameter instead of a framework-owned timed-domain argument__pycircuit_name__StateSignalarithmetic/comparisons were still reading from the original occurrence, which could synthesize bogus balance registers in recurrences likeq.set(q + 1, when=en)Validation
Commands run:
export PYTHONPATH=compiler/frontend; . .venv-ci-mini/bin/activate; pytest tests/unit -m unitexport PYTHONPATH=compiler/frontend; export PYC_TOOLCHAIN_ROOT=$PWD/.pycircuit_out/toolchain/install; . .venv-ci-mini/bin/activate; pytest tests/system -m systemmkdocs buildPYTHONPATH=compiler/frontend python3 flows/tools/check_api_hygiene.py compiler/frontend/pycircuit designs/examples/digital_filter designs/examples/trace_dsl_smoke designs/examples/bundle_probe_expand docs/development README.md CONTRIBUTING.mdPYC_GATE_RUN_ID=20260402-pr-continue PYTHONPATH=compiler/frontend PYC_TOOLCHAIN_ROOT=$PWD/.pycircuit_out/toolchain/install bash flows/scripts/run_semantic_regressions_v40.shEvidence paths:
docs/gates/logs/20260402-pr-continue/Documentation
Docs updated:
README.mdCONTRIBUTING.mddocs/development/index.mddocs/development/contributing-workflow.mddocs/development/testing-and-gates.mddocs/development/review-and-merge.mdAGENTS.md.github/PULL_REQUEST_TEMPLATE.md.github/ISSUE_TEMPLATE/*Risk / Compatibility
domaininto JIT param collectionpre-commit run --all-filesis not yet the routine pathRelated Issues