Update judge command to support custom judge models#7
Merged
Conversation
Co-Authored-By: liren@liquid.ai <liren@liquid.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: liren@liquid.ai <liren@liquid.ai>
Co-Authored-By: liren@liquid.ai <liren@liquid.ai>
Co-Authored-By: liren@liquid.ai <liren@liquid.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Judge Command to Support Custom Judge Models
This PR updates the judge command to support using any model provider for judgment instead of just OpenAI. The following changes were made:
Added new parameters to replace
--openai-api-key:--judge-model-name--judge-model-url--judge-model-api-keyUpdated the following files:
bin/api/run_docker_eval.shbin/api/run_openai_judge.shbin/api/entrypoint.shllm_judge/gen_judgment.pyllm_judge/common.py.github/workflows/run-eval.yamlMaintained backward compatibility with existing
--openai-api-keyparameter.Updated GitHub workflow to use the new parameters.
Resolve https://linear.app/liquid-ai/issue/GEN-370/update-mt-bench-judge-script-to-use-any-llm-provider
Link to Devin run: https://app.devin.ai/sessions/c81627749854419ead0b59881ff887b0
Requested by: liren@liquid.ai