Skip to content

LF-5381 Field Details page crashes when crop is added by another user while session is active #4252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kathyavini merged 4 commits into from
Jul 23, 2026
+30 −12
Merged

LF-5381 Field Details page crashes when crop is added by another user while session is active #4252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b742099
LF-5381 Guard task selectors against plan entities missing from the s…
kathyavini Jul 6, 2026
ead4009
LF-5381 Clean up comments
kathyavini Jul 20, 2026
731b8b5
Merge branch 'integration' into LF-5381-field-details-page-crashes-wh…
kathyavini Jul 20, 2026
4eb76e9
LF-5381 Clarify which plan may be unloaded in guard comments
kathyavini Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/webapp/src/containers/slice/taskSlice/plantTaskSlice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,11 @@ export const plantTasksByManagementPlanIdEntitiesSelector = createSelector(
(plantTaskEntities) => {
return Object.values(plantTaskEntities).reduce(
(plantTasksByManagementPlanIdEntities, plantTask) => {
const { management_plan_id } = plantTask.planting_management_plan;
plantTasksByManagementPlanIdEntities[management_plan_id] = plantTask;
// The planting management plan may not be in the store yet.
const management_plan_id = plantTask.planting_management_plan?.management_plan_id;
if (management_plan_id !== undefined) {
plantTasksByManagementPlanIdEntities[management_plan_id] = plantTask;
}
return plantTasksByManagementPlanIdEntities;
},
{},
Expand Down
6 changes: 5 additions & 1 deletion packages/webapp/src/containers/slice/taskSlice/transplantTaskSlice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,11 @@ export const transplantTasksByManagementPlanIdEntitiesSelector = createSelector(
(transplantTaskEntities) => {
return Object.values(transplantTaskEntities).reduce(
(transplantTasksByManagementPlanIdEntities, transplantTask) => {
const { management_plan_id } = transplantTask.planting_management_plan;
// The planting management plan may not be in the store yet.
const management_plan_id = transplantTask.planting_management_plan?.management_plan_id;
if (management_plan_id === undefined) {
return transplantTasksByManagementPlanIdEntities;
}
if (!transplantTasksByManagementPlanIdEntities[management_plan_id]) {
transplantTasksByManagementPlanIdEntities[management_plan_id] = [];
}
Expand Down
29 changes: 20 additions & 9 deletions packages/webapp/src/containers/taskSlice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,11 @@ export const taskEntitiesSelector = createSelector(
}) => {
const management_plan_id =
plantingManagementPlanEntities[planting_management_plan_id]?.management_plan_id;
// Returns undefined when the planting or management plan is not in the store; both call
// sites below (`managementPlans.map` and the plant/transplant branch) `.filter(Boolean)` it out.
if (!managementPlanEntities[management_plan_id]) {
return undefined;
}
return produce(managementPlanEntities[management_plan_id], (managementPlan) => {
managementPlan.planting_management_plan =
plantingManagementPlanEntities[planting_management_plan_id];
Expand All @@ -243,29 +248,35 @@ export const taskEntitiesSelector = createSelector(
return produce(taskEntities, (taskEntities) => {
for (const task_id in taskEntities) {
taskEntities[task_id].managementPlans =
taskEntities[task_id].managementPlans?.map(getManagementPlanByPlantingManagementPlan) ||
[];
taskEntities[task_id].managementPlans
?.map(getManagementPlanByPlantingManagementPlan)
.filter(Boolean) || [];
// Drop location_ids with no cached location so tasksSelector never reads farm_id off undefined.
taskEntities[task_id].locations =
taskEntities[task_id].locations
?.map((location_id) => locationEntities[location_id])
.filter(Boolean) || [];
const taskType = taskTypeEntities[taskEntities[task_id].task_type_id];
// Task type may not be loaded yet; a task with no type cannot render.
if (!taskType) {
delete taskEntities[task_id];
continue;
}
taskEntities[task_id].taskType = taskType;
const { task_translation_key, farm_id } = taskType;
const subtask = subTaskEntities[task_id];
!farm_id && (taskEntities[task_id][getSubtaskName(task_translation_key)] = subtask);
if (!farm_id && ['PLANT_TASK', 'TRANSPLANT_TASK'].includes(task_translation_key)) {
// Keep the location only when its record is cached, so an unloaded location yields [] not [undefined].
taskEntities[task_id].locations = subtask.planting_management_plan.location_id
? [locationEntities[subtask.planting_management_plan.location_id]].filter(Boolean)
const planting_management_plan = subtask?.planting_management_plan;
taskEntities[task_id].locations = planting_management_plan?.location_id
? [locationEntities[planting_management_plan.location_id]].filter(Boolean)
: [];
taskEntities[task_id].managementPlans = subtask
? [getManagementPlanByPlantingManagementPlan(subtask)].filter(Boolean)
: [];
taskEntities[task_id].managementPlans = [
getManagementPlanByPlantingManagementPlan(subtask),
];
}
taskEntities[task_id].assignee =
userFarmEntities[userFarm.farm_id][taskEntities[task_id].assignee_user_id];
userFarmEntities[userFarm.farm_id]?.[taskEntities[task_id].assignee_user_id];
}
});
},
Expand Down
Loading