Conversation
Contributor
审阅者指南此 PR 通过从 get_currency 中移除 singledispatch 装饰器来重构 CurrencyRepository,以实现更直接的实现,并将软件包版本更新到 0.1.6.post1。 更新后的 CurrencyRepository 类图classDiagram
class CurrencyRepository {
+AsyncSession session
+__init__(session: AsyncSession)
+get_currency(currency_id: str) CurrencyMeta | None
}
文件级别更改
提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表盘以:
获取帮助Original review guide in EnglishReviewer's GuideThis PR refactors CurrencyRepository by removing the singledispatch decorator from get_currency for a more straightforward implementation and updates the package version to 0.1.6.post1. Class diagram for updated CurrencyRepositoryclassDiagram
class CurrencyRepository {
+AsyncSession session
+__init__(session: AsyncSession)
+get_currency(currency_id: str) CurrencyMeta | None
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Member
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
嘿 @JohnRichard4096 - 我已经审阅了你的修改,它们看起来很棒!
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将利用这些反馈来改进你的评论。
Original comment in English
Hey @JohnRichard4096 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
|
@sourcery-ai guide |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcery 总结
改进:
Original summary in English
Sourcery 总结
通过移除 singledispatch 装饰器简化货币获取,并更新包版本
增强:
构建:
Original summary in English
Summary by Sourcery
Simplify currency retrieval by removing singledispatch decorator and update package version
Enhancements:
Build:
@sourcery-ai summary