Skip to content

fix: thread screen indent lines showing before content loads #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Livinglist merged 2 commits into from
Apr 2, 2026
+39 −16
Merged

fix: thread screen indent lines showing before content loads #696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f22d4f
fix: item screen background
Livinglist Apr 2, 2026
905a436
update
Livinglist Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 39 additions & 16 deletions lib/screens/item/widgets/item_screen_background.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import 'package:hacki/config/constants.dart';
import 'package:hacki/cubits/cubits.dart';
import 'package:hacki/extensions/extensions.dart';
import 'package:hacki/screens/widgets/widgets.dart';
import 'package:hacki/styles/styles.dart';
import 'package:hacki/utils/utils.dart';

class ItemScreenBackground extends StatefulWidget {
Expand All @@ -29,30 +30,32 @@ class ItemScreenBackground extends StatefulWidget {

class _ItemScreenBackgroundState extends State<ItemScreenBackground> {
int _shineIndex = 0;
Timer? _timer;
bool _isVisible = false;
bool _overrideCommentsStatus = false;

Timer? _visibilityTimer;
Timer? _overrideTimer;

@override
void initState() {
super.initState();

unawaited(
Future<void>.delayed(
AppDurations.oneSecond,
() {
if (mounted) {
setState(() {
_isVisible = true;
});
}
},
),
);
_visibilityTimer = Timer(AppDurations.oneSecond, () {
if (mounted) {
setState(() => _isVisible = true);
}
});
_overrideTimer = Timer(AppDurations.fiveSeconds, () {
if (mounted) {
setState(() => _overrideCommentsStatus = true);
}
});
}

@override
void dispose() {
_timer?.cancel();
_visibilityTimer?.cancel();
_overrideTimer?.cancel();
super.dispose();
}

Expand All @@ -65,8 +68,9 @@ class _ItemScreenBackgroundState extends State<ItemScreenBackground> {
previous.status != current.status,
listener: (BuildContext context, CommentsState state) {
if (state.status == CommentsStatus.allLoaded && isEyeCandyEnabled) {
_timer?.cancel();
_timer = Timer.periodic(const Duration(milliseconds: 1200), (_) {
_visibilityTimer?.cancel();
_visibilityTimer =
Timer.periodic(const Duration(milliseconds: 1200), (_) {
setState(() {
_shineIndex = (_shineIndex + 1) % (state.maxLevel + 1);
});
Expand All @@ -79,6 +83,25 @@ class _ItemScreenBackgroundState extends State<ItemScreenBackground> {
builder: (BuildContext context, CommentsState state) {
if (!_isVisible || state.comments.isEmpty) {
return const SizedBox.shrink();
} else if (!_overrideCommentsStatus &&
state.status == CommentsStatus.inProgress) {
return FadeIn(
child: Stack(
children: <Widget>[
Positioned(
left: Dimens.zero,
top: Dimens.zero,
bottom: Dimens.zero,
child: RotatedBox(
quarterTurns: 1,
child: LinearProgressIndicator(
minHeight: widget.indentLineWidth,
),
),
),
],
),
);
}
return FadeIn(
child: Stack(
Expand Down