Skip to content

build: refactor build to host-first CMake with nxdk child#151

Open
ReenigneArcher wants to merge 2 commits intomasterfrom
build/refactor
Open

build: refactor build to host-first CMake with nxdk child#151
ReenigneArcher wants to merge 2 commits intomasterfrom
build/refactor

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher commented Apr 2, 2026

Description

Restructure the build to perform a host-native configure/build while driving the Xbox target via an internal nxdk child configure. Added CMake helper modules (cmake/msys2.cmake, cmake/nxdk.cmake, cmake/host-mingw64-clang.cmake, run-child-build.cmake, sources.cmake) and a CLion run configuration (.run/moonlight_xbox.run.xml). Updated CMakeLists to detect/build host tests and optionally add the Xbox child build, and simplified CMakePresets.json for MinGW host builds.

Tooling and scripts updated: add MSYS2 detection helpers (scripts/find-msys2.), remove nxdk wrapper BATs and other outdated helpers, and make build scripts default to cmake-build-release (build.sh, build-mingw64.). CI workflow adjusted to use a configurable CMAKE_BUILD dir and to point artifact, test and coverage paths at that build output. README updated to reflect the new workflow and usage.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.40%. Comparing base (8f32767) to head (8ba4fb1).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   61.40%   61.40%           
=======================================
  Files           2        2           
  Lines          57       57           
  Branches       13       13           
=======================================
  Hits           35       35           
  Misses         17       17           
  Partials        5        5           
Flag Coverage Δ
Linux 61.40% <ø> (ø)
Windows 61.40% <ø> (ø)
macOS 61.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f32767...8ba4fb1. Read the comment docs.

Restructure the build to perform a host-native configure/build while driving the Xbox target via an internal nxdk child configure. Added CMake helper modules (cmake/msys2.cmake, cmake/nxdk.cmake, cmake/host-mingw64-clang.cmake, run-child-build.cmake, sources.cmake) and a CLion run configuration (.run/moonlight_xbox.run.xml). Updated CMakeLists to detect/build host tests and optionally add the Xbox child build, and simplified CMakePresets.json for MinGW host builds.

Tooling and scripts updated: add MSYS2 detection helpers (scripts/find-msys2.*), remove legacy nxdk wrapper BATs and other outdated helpers, and make build scripts default to cmake-build-release (build.sh, build-mingw64.*). CI workflow adjusted to use a configurable CMAKE_BUILD dir and to point artifact, test and coverage paths at that build output. README updated to reflect the new workflow and usage.
@ReenigneArcher ReenigneArcher marked this pull request as ready for review April 2, 2026 03:06
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant