Skip to content

fix(rtsp): ignore clientRefreshRateX100 if more than 1% variance from framerate#5027

Merged
ReenigneArcher merged 1 commit into
masterfrom
feat/config/ignore-client-refresh-rate
Apr 19, 2026
Merged

fix(rtsp): ignore clientRefreshRateX100 if more than 1% variance from framerate#5027
ReenigneArcher merged 1 commit into
masterfrom
feat/config/ignore-client-refresh-rate

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher commented Apr 19, 2026

Description

When testing #4967 I discovered an issue with Moonlight Android on my Pixel 7. Moonlight would report the clientRefreshRateX100 as 4500. I found this strange considering the device has a 90 Hz display. After additional digging I found a couple of other interesting things.

  • In Android Developer settings when enabling "Show refresh rate" it would show either 60 or 90. Not sure what causes it to vary, but even just sitting on the settings screen with nothing happening it would change between the two. Even with this at 90, Moonlight would still only send 4500.
  • There is another Android Developer option, "Disable default frame rate for games". With this enabled, Moonlight would send 9000 which is what I would expect in every case.
  • With "Disable default frame rate for games" disabled, Moonlight will send 6000 if the battery is at 80% or above. At 79% it will send 4500. I did not test other battery ranges so don't know if it further changes the values.

This PR ignores the clientRefreshRateX100 value from the client if there is more than 1% variance.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the feat/config/ignore-client-refresh-rate branch from 2287b61 to 52a69f0 Compare April 19, 2026 01:18
@ReenigneArcher ReenigneArcher changed the title feat(config): ignore client refresh rate fix(rtsp): ignore clientRefreshRateX100 if more than 1% variance from framerate Apr 19, 2026
@ReenigneArcher ReenigneArcher force-pushed the feat/config/ignore-client-refresh-rate branch from 52a69f0 to f5cd27b Compare April 19, 2026 01:27
… framerate

Co-Authored-By: Andy Grundman <105828+andygrundman@users.noreply.github.com>
@ReenigneArcher ReenigneArcher force-pushed the feat/config/ignore-client-refresh-rate branch from f5cd27b to bbe2df0 Compare April 19, 2026 01:55
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.98%. Comparing base (5ffa66e) to head (bbe2df0).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/rtsp.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5027      +/-   ##
==========================================
- Coverage   17.98%   17.98%   -0.01%     
==========================================
  Files         109      109              
  Lines       23502    23508       +6     
  Branches    10373    10375       +2     
==========================================
- Hits         4228     4227       -1     
+ Misses      17757    17756       -1     
- Partials     1517     1525       +8     
Flag Coverage Δ
Archlinux 11.59% <0.00%> (-0.01%) ⬇️
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.58% <0.00%> (+0.01%) ⬆️
Homebrew-ubuntu-22.04 13.97% <0.00%> (-0.01%) ⬇️
Linux-AppImage 12.26% <0.00%> (-0.01%) ⬇️
Windows-AMD64 14.90% <0.00%> (-0.01%) ⬇️
Windows-ARM64 13.22% <0.00%> (+<0.01%) ⬆️
macOS-arm64 19.01% <0.00%> (-0.02%) ⬇️
macOS-x86_64 18.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/rtsp.cpp 2.42% <0.00%> (+0.13%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffa66e...bbe2df0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant