Skip to content

fix(ffmpeg): only do git fetch for dependencies we're actually building#687

Open
chewi wants to merge 1 commit into
LizardByte:masterfrom
chewi:git-if-needed
Open

fix(ffmpeg): only do git fetch for dependencies we're actually building#687
chewi wants to merge 1 commit into
LizardByte:masterfrom
chewi:git-if-needed

Conversation

@chewi
Copy link
Copy Markdown
Contributor

@chewi chewi commented May 21, 2026

Description

Only do git fetch for dependencies we're actually building. Gentoo uses the system-wide versions, so these directories are empty, causing git to fail.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Gentoo uses the system-wide versions, so these directories are empty,
causing git to fail.

Signed-off-by: James Le Cuirot <chewi@gentoo.org>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little harder to maintain if more dependencies need this pattern in the future. As a compromise can you make a re-usable macro where we just pass in the submodule path as an argument?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants