fix(ffmpeg): only do git fetch for dependencies we're actually building#687
Open
chewi wants to merge 1 commit into
Open
fix(ffmpeg): only do git fetch for dependencies we're actually building#687chewi wants to merge 1 commit into
chewi wants to merge 1 commit into
Conversation
Gentoo uses the system-wide versions, so these directories are empty, causing git to fail. Signed-off-by: James Le Cuirot <chewi@gentoo.org>
|
Member
ReenigneArcher
left a comment
There was a problem hiding this comment.
This is a little harder to maintain if more dependencies need this pattern in the future. As a compromise can you make a re-usable macro where we just pass in the submodule path as an argument?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Only do git fetch for dependencies we're actually building. Gentoo uses the system-wide versions, so these directories are empty, causing git to fail.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage