Skip to content

refactor: supporter row centering and SVG dimension extraction#50

Merged
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/remove-uselss-variables
Nov 30, 2025
Merged

refactor: supporter row centering and SVG dimension extraction#50
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/remove-uselss-variables

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Simplifies calculation of supporter row starting X position in contribkit.config.ts by using a local variable. Updates svg-utils.ts to ignore unused viewBox values when extracting SVG dimensions, improving code clarity.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Simplifies calculation of supporter row starting X position in contribkit.config.ts by using a local variable. Updates svg-utils.ts to ignore unused viewBox values when extracting SVG dimensions, improving code clarity.
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher marked this pull request as ready for review November 30, 2025 23:29
@ReenigneArcher ReenigneArcher merged commit b3fed6d into master Nov 30, 2025
13 of 14 checks passed
@ReenigneArcher ReenigneArcher deleted the refactor/sonar/remove-uselss-variables branch November 30, 2025 23:29
@codecov

codecov Bot commented Nov 30, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 34.69%. Comparing base (439a439) to head (7911b74).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
configs/sponsors/contribkit.config.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   33.33%   34.69%   +1.36%     
==========================================
  Files           2        2              
  Lines          51       49       -2     
  Branches        8        8              
==========================================
  Hits           17       17              
+ Misses         34       32       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant