Skip to content

refactor: SVG attribute matching to use RegExp.exec #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Dec 1, 2025
Merged

refactor: SVG attribute matching to use RegExp.exec #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions configs/sponsors/svg-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
*/
export function extractSvgDimensions(svgContent: string): { width: number; height: number } {
// Try to get dimensions from viewBox first
const viewBoxMatch = svgContent.match(/viewBox=['"]([^'"]*)['"]/);
const viewBoxRegex = /viewBox=['"]([^'"]*)['"]/;
const viewBoxMatch = viewBoxRegex.exec(svgContent);
if (viewBoxMatch) {
const [, , width, height] = viewBoxMatch[1].split(/\s+/).map(Number);
// Check that both width and height are valid numbers (not NaN and not undefined)
Expand All @@ -19,8 +20,10 @@ export function extractSvgDimensions(svgContent: string): { width: number; heigh
}

// Try to get from width/height attributes
const widthMatch = svgContent.match(/width=['"]([^'"]*)['"]/);
const heightMatch = svgContent.match(/height=['"]([^'"]*)['"]/);
const widthRegex = /width=['"]([^'"]*)['"]/;
const widthMatch = widthRegex.exec(svgContent);
const heightRegex = /height=['"]([^'"]*)['"]/;
const heightMatch = heightRegex.exec(svgContent);

const width = widthMatch ? Number.parseInt(widthMatch[1], 10) : 200;
const height = heightMatch ? Number.parseInt(heightMatch[1], 10) : 100;
Expand Down