feat: windows implementation#19
Draft
ReenigneArcher wants to merge 5 commits into
Draft
Conversation
Documentation build overview
135 files changed ·
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 87.05% 81.61% -5.45%
==========================================
Files 10 12 +2
Lines 3152 3579 +427
Branches 1109 1229 +120
==========================================
+ Hits 2744 2921 +177
- Misses 250 508 +258
+ Partials 158 150 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
ReenigneArcher
force-pushed
the
feat/windows-implementation
branch
3 times, most recently
from
3312431 to
f919c1f
Compare
ReenigneArcher
force-pushed
the
feat/windows-implementation
branch
4 times, most recently
from
8f275cf to
24ed49a
Compare
Refine Windows packaging and driver build integration: - cmake/packaging/windows.cmake: configure CPack for driver component when building driver and set CPACK_INSTALL_CMAKE_PROJECTS for driver installs. - cmake/packaging/windows_wix.cmake: point CPACK_WIX_EXTENSIONS to the full WixToolset.UI extension DLL path and remove use of a separate patch file. - Remove wix_resources/patch.xml and the FeatureRef from libvirtualhid-driver-installer.wxs. - src/platform/windows/driver/CMakeLists.txt: normalize and deduplicate WDK root paths, search for UM import libraries (ntdll) and expose LIBVIRTUALHID_NTDLL_LIBRARY; update error messages; link ntdll; restructure custom targets to prepare/stamp the INF and then generate the driver catalog with proper dependencies and working directories. - src/platform/windows/driver/libvirtualhid.inf.in: add SourceDisksNames/Files and DiskName entry so the INF lists source disk information. - src/platform/windows/windows_backend.cpp: replace getenv usage with GetEnvironmentVariableA for robust environment variable reading and remove unused <cstdlib> include. These changes improve robustness when locating WDK components, produce correct installer inputs, and make INF/catalog generation deterministic in the build.
ReenigneArcher
force-pushed
the
feat/windows-implementation
branch
2 times, most recently
from
4461727 to
98df18a
Compare
Refactor WiX packaging CMake: add WIX_BUILD_DIRECTORY and set a comment about UI extension versioning, always run dotnet tool install for WiX and fail on install errors, and add installation of the WixToolset.Util extension with error handling. Replace a hardcoded extension DLL path with logical extension names in CPACK_WIX_EXTENSIONS and emit the cpack package directory for debugging. These changes make extension installation more robust and simplify extension referencing for packaging.
ReenigneArcher
force-pushed
the
feat/windows-implementation
branch
3 times, most recently
from
44c2a75 to
2dc8581
Compare
ReenigneArcher
force-pushed
the
feat/windows-implementation
branch
from
2dc8581 to
db8e222
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Windows implementation.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage