fix: require Python 3.14 and handle bot shutdown race#534
Merged
Conversation
Bump pyproject minimum Python version and classifier to 3.14. In the bot, add an internal _stopping flag and a _run_threaded helper to run the event loop and suppress the "Session is closed" RuntimeError when shutdown is in progress. start_threaded now uses _run_threaded and sets _stopping=False, while shutdown sets _stopping=True before closing to avoid a race when stopping the threaded bot.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #534 +/- ##
==========================================
+ Coverage 61.47% 61.63% +0.16%
==========================================
Files 27 27
Lines 1978 1989 +11
==========================================
+ Hits 1216 1226 +10
- Misses 762 763 +1
Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Bump pyproject minimum Python version and classifier to 3.14. In the bot, add an internal _stopping flag and a _run_threaded helper to run the event loop and suppress the "Session is closed" RuntimeError when shutdown is in progress. start_threaded now uses _run_threaded and sets _stopping=False, while shutdown sets _stopping=True before closing to avoid a race when stopping the threaded bot.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage