Open
Conversation
Collaborator
|
can you run a comparison of gas usage before and after your optimizations? npm test test/lendingPool.js should give you gas costs |
0xngmi
reviewed
Oct 11, 2022
| uint216 currentDailyBorrows; // would have to borrow more eth than will ever exist daily to break | ||
| uint40 lastUpdateDailyBorrows; | ||
| mapping(address => bool) public liquidators; | ||
| mapping(address => uint) public liquidators; |
Collaborator
There was a problem hiding this comment.
have you verified that this is in fact cheaper? i think it should be but havent verified it
Author
There was a problem hiding this comment.
Saves 16168 gas on deployment and a whopping 12 gas on addLiquidator()
0xngmi
reviewed
Oct 11, 2022
0xngmi
reviewed
Oct 11, 2022
0xngmi
reviewed
Oct 11, 2022
0xngmi
reviewed
Oct 11, 2022
0xngmi
reviewed
Oct 13, 2022
| } else { | ||
| currentDailyBorrows = uint216(currentDailyBorrows - toReduce) + toAdd; | ||
| unchecked { | ||
| // Resulting daily borrow has to be over 10^47 ETH |
Collaborator
There was a problem hiding this comment.
this is safu because we know toReduce <= currentDailyBorrows, so (currentDailyBorrows - toReduce) >= 0
Author
|
wen merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.