CargoHoldTracker: support quick deposit#219
Open
dekvall wants to merge 1 commit intoLlemonDuck:mainfrom
Open
Conversation
BBeeaarr
reviewed
Feb 20, 2026
| if (pendingQuickDepositAction) | ||
| { | ||
| pendingInventoryAction = 1; // tick goes last | ||
| log.debug("inv change queued pendingInventoryAction with inventory {}", memoizedInventory); |
There was a problem hiding this comment.
This is still failure prone to inventory changes after clicking Deposit-all and before the deposit action occurs
IE dropping an item while running to the chest.
I don't think a proximity check will be perfect here either. Any inventory changes that occur on the same tick as the deposit will be included in the UI storage status even if adjacent to the chest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only tested while salvaging with the sloop ironwood cargo hold but I presume the logic should hold for the others as well.
If you want a proximity check too just lmk, but idk if it's necessary.
Closes #177