Open
Conversation
Still validating via playtesting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new optional notification on the cargo hold becoming full.
This is in addressing this issue #225 I raised on the subject
This relies on the existing CargoHoldTracker behavior which isn't perfectly reliable but is good enough for most uses.
The particular approach here should eventually catch the full cargo hold even if it doesn't do so immediately, but shouldn't ever emit false positives as false notifications would be very frustrating.
The configuration option is off by default and must be explicitly enabled in the Cargo Hold Tracking section of the sailing plugin config.