test(stripe_controller): add webhook endpoint tests#3308
Open
laraujo7 wants to merge 2 commits intoLogflare:mainfrom
Open
test(stripe_controller): add webhook endpoint tests#3308laraujo7 wants to merge 2 commits intoLogflare:mainfrom
laraujo7 wants to merge 2 commits intoLogflare:mainfrom
Conversation
Ziinc
requested changes
Mar 26, 2026
laraujo7
force-pushed
the
la/stripe_controller-test
branch
3 times, most recently
from
5630daa to
62587b9
Compare
Ziinc
requested changes
Apr 2, 2026
| assert Billing.get_billing_account_by(stripe_customer: ba.stripe_customer).id == ba.id | ||
|
|
||
| assert Billing.get_billing_account_by(stripe_customer: ba.stripe_customer).lifetime_plan == | ||
| ba.lifetime_plan |
Contributor
There was a problem hiding this comment.
Why compare on this field specifically? Why not do a before/after struct comparison?
Contributor
There was a problem hiding this comment.
Doing so with a struct comparison would be more comprehensive as well
Contributor
There was a problem hiding this comment.
Wouldn't the id be enough though? I can do a struct comparison if you see it as better in this case 🙏
Contributor
There was a problem hiding this comment.
I did full struct comparison and extracted the util TestUtils.reset_associations/1 🙏
nelsonmestevao
force-pushed
the
la/stripe_controller-test
branch
3 times, most recently
from
457df94 to
531a2a0
Compare
nelsonmestevao
approved these changes
Apr 7, 2026
| assert Billing.get_billing_account_by(stripe_customer: ba.stripe_customer).id == ba.id | ||
|
|
||
| assert Billing.get_billing_account_by(stripe_customer: ba.stripe_customer).lifetime_plan == | ||
| ba.lifetime_plan |
Contributor
There was a problem hiding this comment.
I did full struct comparison and extracted the util TestUtils.reset_associations/1 🙏
nelsonmestevao
force-pushed
the
la/stripe_controller-test
branch
5 times, most recently
from
7265a0a to
2d76d47
Compare
laraujo7
force-pushed
the
la/stripe_controller-test
branch
from
90f3851 to
b76f987
Compare
laraujo7
force-pushed
the
la/stripe_controller-test
branch
3 times, most recently
from
89bd6a1 to
d933fca
Compare
Revert 'query/cache tuning changes' (Logflare#3348) (Logflare#3354) * Revert "chore: query/cache tuning for hot query paths (Logflare#3348)" This reverts commit 93157ab. * version bump
laraujo7
force-pushed
the
la/stripe_controller-test
branch
from
d933fca to
63d8f97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix get_payment_method_by/1 typespec to include nil return and minor formatting cleanup