Skip to content

chore: Remove ClickHouse from Webhook adapter moduledoc #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amokan merged 1 commit into from
Apr 6, 2026
Merged

chore: Remove ClickHouse from Webhook adapter moduledoc #3345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/logflare/backends/adaptor/webhook_adaptor.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@moduledoc """
Backend adaptor for webhooks / HTTP posts.

A number of other adaptors (_ClickHouse, DataDog, Elastic, Loki, etc_) leverage this to handle the final HTTP transaction.
A number of other adaptors (_DataDog, Elastic, Loki, etc_) leverage this to handle the final HTTP transaction.

### Finch Pool Selection

Expand All @@ -15,8 +15,6 @@

This adaptor performs a merge on config that will prevent you from leveraging a dynamically generated URL configuration at runtime.
To bypass this behavior, you can use the optional `:url_override` attribute.

See the `Logflare.Backends.Adaptor.ClickHouseWebhookAdaptor` for an example that utilizes this.
"""

use GenServer
Expand Down Expand Up @@ -276,7 +274,7 @@
end

def ack(_ack_ref, _successful, _failed) do
# TODO: re-queue failed

Check warning on line 277 in lib/logflare/backends/adaptor/webhook_adaptor.ex

View workflow job for this annotation

GitHub Actions / Checks (Code Quality - Linting, mix lint.all) 

Found a TODO tag in a comment: # TODO: re-queue failed
end
end
end
Loading