HARD FAULT : Add sanity check to sx126x driver when handling retention list#1615
Open
MarekNovakACRIOS wants to merge 1 commit intoLora-net:masterfrom
Open
HARD FAULT : Add sanity check to sx126x driver when handling retention list#1615MarekNovakACRIOS wants to merge 1 commit intoLora-net:masterfrom
MarekNovakACRIOS wants to merge 1 commit intoLora-net:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same as described here applies: Lora-net/SWL2001#72
In one sentence - without the sanity check, reading ouf of bounds of an array placed on stack can happen -> this will cause reading outside of RAM/SRAM region, due to stack being placed at the end of SRAM/RAM region -> this will generate a hardfault or a memfault or take down the system...