Skip to content

feat: SRAM_read - attempt to load save files regardless of user compression setting #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frysee merged 2 commits into from
Mar 2, 2026
Merged

feat: SRAM_read - attempt to load save files regardless of user compression setting #667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9b8762
feat: SRAM_read load gamesave even if compress/raw file does not matc…
DrFlarp Mar 1, 2026
eee709f
indentation
DrFlarp Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions workspace/all/minarch/minarch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,27 +825,14 @@ static void SRAM_read(void) {
void* sram = core.get_memory_data(RETRO_MEMORY_SAVE_RAM);

#ifdef HAS_SRM
// TODO: rzipstream_open can also handle uncompressed, else branch is probably unnecessary
// srm, potentially compressed
if (CFG_getSaveFormat() == SAVE_FORMAT_SRM) {
rzipstream_t* sram_file = rzipstream_open(filename, RETRO_VFS_FILE_ACCESS_READ);
if(!sram_file) return;

if (!sram || rzipstream_read(sram_file, sram, sram_size) < 0)
LOG_error("rzipstream: Error reading SRAM data\n");

rzipstream_close(sram_file);
}
// uncompressed
else {
RFILE* sram_file = filestream_open(filename, RETRO_VFS_FILE_ACCESS_READ, 0);
if(!sram_file) return;
rzipstream_t* sram_file = rzipstream_open(filename, RETRO_VFS_FILE_ACCESS_READ);
if(!sram_file) return;

if (!sram || filestream_read(sram_file, sram, sram_size) < 0)
LOG_error("filestream: Error reading SRAM data\n");
if (!sram || rzipstream_read(sram_file, sram, sram_size) < 0)
LOG_error("rzipstream: Error reading SRAM data\n");

filestream_close(sram_file);
}
rzipstream_close(sram_file);
#else
FILE *sram_file = fopen(filename, "r");
if (!sram_file) return;
Expand Down
Loading