ci: Bump actions/setup-node from 4 to 6 - #1
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 6. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v6) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
taibaran
added a commit
that referenced
this pull request
May 20, 2026
…e + cosmetics
Round-7 had 1 of 3 reviewers APPROVE (Grok "ready to merge"); Gemini
flagged 1 Important + 1 nit, Codex 1 P1 + 1 P2. Round-8 closes 3 of
those 4 (1 P2 deferred to v0.6.1, documented in CHANGELOG).
Fixes:
- _scanLastBalancedJson: counts UNMATCHED braces only toward the
SCAN_MAX_ATTEMPTS=256 cap. Round-7 incremented unconditionally per
`{`, so a legitimate output with 300+ matched JSON blocks before
the verdict would prematurely abort. Matched blocks advance by
their full length (O(n) per level) — the only DoS vector lives
in the unmatched branch (advance 1 byte). Gemini round-7 #1
Important. New regression test pins 300 matched + verdict.
- extractJsonObject: strategy-0 tries JSON.parse(trimmed) BEFORE
fence extraction. If the model returned valid top-level JSON
whose string-valued fields contained an embedded ```json fence
(realistic case for review --json's findings[i].suggestion text),
the round-7 extractor matched the inner fence first and returned
the example object, corrupting output. Codex round-7 P1. New
regression test pins the embedded-fence-in-field case.
- Defensive `return` after `emitInfraFailure("review gate timed
out")`. Matches the round-6 style for emitAllow/emitBlock.
Gemini round-7 nit.
- "Gemini review gate (strict)" → "agy review gate (strict)" in
stop-hook fail-closed message. Wording inconsistency leftover
from the round-1 sweep. Grok round-7 cosmetic.
Deferred to v0.6.1 (acknowledged):
- Codex P2: schema-aware first-vs-last in parseVerdict (current
last-wins is correct for "thinking → final"; bounded impact).
- Grok low-1: dead `if (probe.fallbackUsed)` block in cmdSetup
(pure cleanup, no behavior change since fallback chain is empty).
Tests (+2 net, 135 → 137):
- 300 matched balanced blocks before verdict still parsed.
- Top-level JSON with embedded ```json fence in a string value
returns the outer object.
Live smoke (agy 1.0.0):
- /gemini:setup: ✅ working
- /gemini:ask: captured ROUND8OK cleanly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/setup-node from 4 to 6.
Release notes
Sourced from actions/setup-node's releases.
... (truncated)
Commits
48b55a0Update Node.js versions in versions.yml and bump package to v6.4.0 (#1533)ab72c7eUpgrade@actionsdependencies (#1525)53b8394Bump minimatch from 3.1.2 to 3.1.5 (#1498)54045abScope test lockfiles by package manager and update cache tests (#1495)c882bffReplace uuid with crypto.randomUUID() (#1378)774c1d6feat(node-version-file): support parsingdevEnginesfield (#1283)efcb663fix: remove hardcoded bearer (#1467)d02c89dFix npm audit issues (#1491)6044e13Docs: bump actions/checkout from v5 to v6 (#1468)8e49463Fix README typo (#1226)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)