Open
Conversation
- Added MuRAT3.m as the main entry point for the MuRAT 3D attenuation tomography workflow, along with new input files for Mount St. Helens, Romania, and Toba examples. -Removed legacy .mlx scripts and IRtools.zip. -Introduced new and reorganized utility and processing scripts under bin/ and Utilities_Matlab/PrePostProcessing. - \bin includes new modules for diffusion, hitmap, inversion, smoothing, and plotting. - Updated configuration and velocity model files, and removed deprecated minimization and weighting scripts. - This refactor streamlines the codebase for MuRAT3 and prepares it for new datasets and workflows.
Expanded .gitignore to cover more OS, MATLAB, and binary files. Updated README to reflect new contributors, version, and workflow, and removed references to IRTools as a submodule. Deleted .gitmodules since IRTools is no longer included as a submodule.
Fixed the test badge link to point to the correct repository, updated the Zenodo DOI link formatting, and made minor whitespace and formatting corrections for clarity.
…test Simplifies and clarifies Qc selection and data warning logic by removing the QcM argument from Murat_dataWarning and related calls, updating threshold checks, and improving output messages. Fixes indexing in inversion routines, adjusts weighting in Qc inversion, and refines declustering and ray crossing criteria. Removes unused addTopLevelFoldersToPath.m file.
Standardized headers in input files to 'MuRAT', updated version and parameter values in Murat_inputRomania.m and Murat_inputToba.m, enabled inversion plotting in Murat_inputMSH.m, and deleted the velocity_models/iasp91.txt file.
Refactored bin/Murat_inversion.m to use more descriptive variable names, reduce repeated allocations, and streamline buffer reuse. Improved frequency loop structure, consolidated output assignments, and moved writetable for muratHeader to bin/Murat_testData.m. Minor formatting and whitespace adjustments in bin/Murat_dataParallelized.m and bin/Murat_plot.m.
Modernizes MuRAT.m with improved folder handling, toolbox requirements, and file saving logic. Updates input parameters in Murat_inputMSH.m for finer linear fit threshold and disables plotting during inversion. Removes unused variables and redundant file writing in Murat_inversion.m and Murat_testData.m. Murat_checks.m now writes header information to an Excel file in a consistent location.
LucaDeSiena
requested review from
CNardoni,
DonatoTalone,
SimonaGabrielli,
ferdinandonapolitano and
mreissuf
Replaces a simple addpath call with logic to recursively add only relevant subfolders of Utilities_Matlab. This prevents unnecessary or unwanted folders from being added to the MATLAB path.
…roducibility - fixed incorrect geographic midpoint calculation by vectorizing "mean()" inputs in Murat_checks.m - added L-curves figures to be saved as .fig in Murat_inversionQ.m and Murat_inversionQc.m - moved shared data computations to the start of each frequency loop iteration, ensuring all plot switches operate independently in Murat_plot.m - forced figures background as white and text as black in saveFigureAsImage.m
Added if statement to consider differences in thresholds for the Linear and NonLinear cases.
Inputs now allow inclusion of 1D models again, iasp91 style.
Owner
Author
|
Please download and check that 1D models now work @martinaavella |
Include a Zenodo DOI badge in the README to show the archived release/DOI (badge ID 64924529). The badge is added alongside the existing CI/test badge to make the project's DOI/archival record more visible.
Bump project name to MuRAT4.0 and clarify doc/instruction details.
Add envelope function in bin and readme on how to use it in input file. also modified line 52 in Murat_Qc.m
Added the envelopeSmoothTime parameter to all example input files (MSH, Romania, Toba) in the Waveform Data section, ensuring consistency with the updated Murat_envelope.m function and README documentation
Update Qc measurement defaults and thresholds in input presets and fix computations in the processing scripts: - Murat_inputMSH.m: increase fitTresholdLinear from 0.0001 to 0.006 for NonLinear QcMeasurement. - Murat_inputRomania.m: switch QcMeasurement from 'NonLinear' to 'Linearized' and set fitTresholdLinear to 0.3. - bin/Murat_Qc.m: ensure uncertaintyFit is non-negative by taking the absolute value of the log-based expression. - bin/Murat_inversionQc.m: disable (comment out) the min-max normalization of the weight vector w so the original weighting from RZZ_k is preserved. These changes adjust default measurement modes/thresholds and make the uncertainty and weighting behavior more robust/consistent. Co-Authored-By: GaiaCaporale <188322017+GaiaCaporale@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MuRAT4 implements long-awaited enhancements, especially:
*Differential kernels for Qc imaging
*Albedo and extinction length dependency on CN and Qc methods
*Brand new inversion tools
*Possibility of skipping time-consuming plotting
*Revamped computational structures for all functions
I need help by:
*Running and checking existing templates, providing feedback
*Applying the new code to your existing dataset.
*Improve documentation, especially the README.
This review is only for senior MuRAT contributors.