Merged
Conversation
Add envelope function in bin and readme on how to use it in input file. also modified line 52 in Murat_Qc.m
LucaDeSiena
requested changes
Mar 19, 2026
Owner
LucaDeSiena
left a comment
LucaDeSiena
left a comment
There was a problem hiding this comment.
Thanks, please also update the three template .m files (MSH, Romania and Toba) with the content of the readme.
Added the envelopeSmoothTime parameter to all example input files (MSH, Romania, Toba) in the Waveform Data section, ensuring consistency with the updated Murat_envelope.m function and README documentation
Collaborator
Author
|
Ciao Luca,
È arrivata la risposta?
Solo per conferma, quindi giovedì cancelliamo la riunione?
Gaia
Il giorno gio 19 mar 2026 alle 13:19 Luca De Siena ***@***.***>
ha scritto:
… ***@***.**** requested changes on this pull request.
Thanks, please also update the three template .m files (MSH, Romania and
Toba) with the content of the readme.
—
Reply to this email directly, view it on GitHub
<#47 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BM4ZBYNNH75A7NSBKGOZO2L4RPQTVAVCNFSM6AAAAACWXYYCNGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSNZUG4YTEMZSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
LucaDeSiena
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add envelope function in bin and readme on how to use it in input file. also modified line 52 in Murat_Qc.m