perf(cuda): recover qwen dense decode path#27
Open
dusterbloom wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Split out the second concern that used to ride in #24.
This PR keeps the dense decode recovery work independent of the in-place GDN state-write API:
ggml_cuda_set_skip_props_check)WRITE_INTERspecialization so pure AR cancompile out that store path
DFLASH_GDN_FORCE_GROUPED_COLS/DFLASH_GDN_NO_GROUPED_COLSoverridesRelationship to #24
#24 is now only the in-place final-state write API/kernel path.
This branch is based directly on
luce-dflash, so reviewers can inspect it as a separate concern.The Lucebox consumer can combine #24 and this PR to recover the local dense AR replay fast path
without mixing unrelated ggml changes in one PR.
Validation
Built both split branches locally with CUDA 12.6 and explicit SM86 because this environment cannot
probe
CUDA_ARCHITECTURES=nativewithout a visible GPU:env CUDACXX=/usr/local/cuda/bin/nvcc cmake -S /tmp/ggml-pr24-inplace -B /tmp/ggml-pr24-inplace/ build-cuda126-sm86 -DGGML_CUDA=ON -DGGML_CCACHE=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_CUDA_ARCHITECTURES=86cmake --build /tmp/ggml-pr24-inplace/build-cuda126-sm86 --target ggml-cuda -j 8env CUDACXX=/usr/local/cuda/bin/nvcc cmake -S /tmp/ggml-pr24-props-independent -B /tmp/ggml-pr24- props-independent/build-cuda126-sm86 -DGGML_CUDA=ON -DGGML_CCACHE=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_CUDA_ARCHITECTURES=86cmake --build /tmp/ggml-pr24-props-independent/build-cuda126-sm86 --target ggml-cuda -j 8