Phase 1: Fix 8 bugs, add Cancel Orders and Get Order endpoints#1
Merged
Merged
Conversation
Bug fixes:
- Fix CancellationToken never propagated through Polly policies or ICoinbaseApi
- Fix OrderSearchRequest missing [AliasAs] attributes (sent PascalCase instead of snake_case)
- Remove unused duplicate order config types from GetOrdersResponse.cs
- Fix BaseSize type inconsistencies (decimal/double → string) in order models
- Replace non-cryptographic Random with RandomNumberGenerator in JWT nonce
- Fix SandboxBaseUrl default to actual Coinbase sandbox URL
- Fix GetProduct return type from Task<string> to Task<AdvancedTradeProduct>
- Fix non-compiling examples and incorrect README code samples
New endpoints:
- CancelOrdersAsync (POST /orders/batch_cancel)
- GetOrderAsync (GET /orders/historical/{orderId})
- GetProductAsync wrapper on typed GetProduct
Tests: 12 new tests (62 total), all passing. Formatting clean.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /orders/batch_cancel) withCancelOrdersAsync,CancelOrdersRequest/CancelOrdersResponsemodelsGET /orders/historical/{orderId}) withGetOrderAsync,GetOrderResponsemodelGetProductAsyncnow returnsAdvancedTradeProductinstead of raw stringBug Details
new Random()instead ofRandomNumberGeneratorCoinbaseApiException, wrongOrderSide.BuyGetProductreturnedTask<string>instead of typed modelTest plan
dotnet build— 0 errorsdotnet format --verify-no-changes— clean🤖 Generated with Claude Code