ci: replace manual versioning with release-please#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the manual
<Version>+ tag-driven publish pipeline with release-please on Conventional Commits. The package version becomes managed entirely by release-please via.release-please-manifest.json, and a singlerelease-please.ymlworkflow opens Release PRs and pushes to NuGet.org when those PRs are merged..release-please-manifest.json(seeded0.0.0). The csproj has no<Version>or<PackageReleaseNotes>..github/workflows/release-please.ymlruns on every push tomain, opens/updates a Release PR, and on merge tags + publishes viadotnet pack /p:Version=$VERSION→dotnet nuget push.developbranch andv*tag triggers are gone.ci.ymlis now a pure build/test/format/analyzers/security workflow onmainonly.build.ymlandpublish-nuget.yml(both superseded).CONTRIBUTING.mddocuments the Conventional Commits requirement;CLAUDE.mddescribes the new release flow; the bug template's version placeholder is refreshed.File changes
release-please-config.json.release-please-manifest.json0.0.0)CHANGELOG.md.github/workflows/release-please.yml.github/workflows/ci.yml.github/workflows/build.yml.github/workflows/publish-nuget.ymlCoinbase.AdvancedTrade.Client/Coinbase.AdvancedTrade.Client.csproj<Version>and<PackageReleaseNotes>CONTRIBUTING.md## Commit MessagessectionCLAUDE.md## CI/CDand## Releases.github/ISSUE_TEMPLATE/bug_report.md.gitignoredocs/superpowers/(planning artifacts)How the new release flow works
mainusing Conventional Commits (feat:,fix:,feat!:, etc.).release-please.ymlopens or updates achore(main): release X.Y.ZPR with the next version and a changelog.vX.Y.Ztag and a GitHub Release; the same workflow'spublishjob builds with/p:Version=X.Y.Z, packs, and pushes to NuGet.org.feat:→ patch bump,feat!:→ minor bump. To cut 1.0.0, push a commit with footerRelease-As: 1.0.0.Maintainer post-merge checklist
These are one-time, destructive operations the maintainer needs to do after this PR merges (they are not automated):
developbranch (local + remote) if present:main— remove any required checks that reference the deleted workflow names (Build and Test,Publish to NuGet.org). PRs will be unmergeable until these are removed.NUGET_API_KEYsecret is still present and valid in GitHub Actions.chore:/ci:/docs:), so release-please will not open a Release PR until a realfeat:orfix:lands. Either:feat: replace manual versioning with release-please(will trigger an immediate0.0.1Release PR), ORfix:orfeat:commit afterward to bootstrap the flow.Test plan
dotnet build -c Release— clean (0 errors, 0 warnings)dotnet test -c Release— 116/116 passing (102 unit + 14 integration)dotnet format --verify-no-changes— exit 0release-please-config.jsonand.release-please-manifest.jsonvalidatedotnet pack ... /p:Version=0.0.1producesCoinbase.AdvancedTrade.Client.0.0.1.nupkg(verified locally — confirms the CI publish step's version injection works)release-please.ymlruns successfully on the merge commitpublishjob tags, releases, and pushes to NuGet.org🤖 Generated with Claude Code