Issue 710: refactor js - #711
Conversation
| else { | ||
| const pop = topWin.open(url, 'dictwin', settings); | ||
| topWin.lute_popup_window = pop; | ||
| if (!topWin.lute_popup_windows) { |
There was a problem hiding this comment.
@marcomachado - I'm not clear why we need the lute_popup_windows array, since there's only one popup open at a time. Thoughts?
There was a problem hiding this comment.
@marcomachado - I'm not clear why we need the
lute_popup_windowsarray, since there's only one popup open at a time. Thoughts?
This part it's not necessary, that was my mistake. When I first started on this task, I was trying to reuse one popup per external dictionary (which would require tracking them in an array). Later, I changed it to use a single external popup (dictwin), but forgot to clean up the array tracking logic.
I will update the logic to only track the active window (topWin.lute_popup_window) and remove the redundant lute_popup_windows array.
There was a problem hiding this comment.
@marcomachado - no problem, I actually have the branch open already on my machine, it's a quick fix. I'll take care of it, thanks!
There was a problem hiding this comment.
Not sure how I missed it in the initial code review, my mistake on that side anyway. Cheers!
|
Just a question to @marcomachado -- otherwise this PR should be good to go. |
2 participants
For issue #710