Feat/home tag filter - #716
Closed
chengxicx wants to merge 3 commits into
Closed
Conversation
added 3 commits
July 25, 2026 01:28
- Add LgIsActive column to languages table (default 1 = active) - Add Freeze/Activate action buttons in language list - Filter frozen languages from language dropdowns and current language validation - Gracefully handle invalid current_language_id after backup restore
- Clickable tag pills in Tags column to filter books by tag - Active tag filter indicator in header with clear button - Sortable table headers for Title, Language, Tags columns - Status label renamed from "Statuses" to "Status" - Status bar click shows count tooltip
- Add visual dot separator between adjacent tags in Tags column - Wrap tags in .book-tag-list container with flex layout - Increase Tags column width from 10% to 18% for better readability - Add header column border separators for visual organization - Add text overflow handling for long tag names - Distribute remaining column widths more proportionally
chengxicx
force-pushed
the
feat/home-tag-filter
branch
from
July 24, 2026 17:29
ee8f65a to
88903c6
Compare
jzohrab
added
the
wont-merge
Collaborator
|
Hi @chengxicx -- this PR contains code from a few different fixes, and so can't be considered for merging. If I merge this, I'm merging everything done before it, so that is a big risk from the code review standpoint. See the guidelines at https://github.com/LuteOrg/lute-v3/wiki/Contributing#do-one-thing for notes. If you can pull out the commits with cherry-pick or similar and put them into a separate PR, that would be possible to look it. As it is, I'm going to close this one. Cheers and thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home Page Tag Filtering & Table Sorting
UX improvements for the main book list table:
Clickable tag filters: Tags within the Tags column are interactive; clicking a tag filters the list to only matching books
Active filter indicator: The table header displays all currently applied tag filters alongside a one-click clear button
Sortable columns: Clickable headers for Title, Language, and Tags support ascending/descending sorting
Consistent status labeling: Renames the "Statuses" table header to unified singular "Status"
Status breakdown tooltip: Clickable bottom status bar shows a popover with exact count breakdowns for each reading status