Added four new acceptance tests RE Issue 4 - #723
Conversation
…nu, default backup settings being unchanged, deleting a book from the home page, and searching for terms.
|
Thank you @TomStudies ! Running CI on it now, if any issues pop up you should get an email. |
jzohrab
left a comment
jzohrab
left a comment
There was a problem hiding this comment.
A request to remove some duplication, if you have time. If you don't, let me know and I should be able to do it quickly too. Cheers and thank you!
| # print(f"RAW ROWSTRINGs = {rowstring}", flush=True) | ||
| return "\n".join([r for r in rowstring if r.strip() != ""]).strip() | ||
|
|
||
| def get_filtered_term_table_content(self): |
There was a problem hiding this comment.
Hi @TomStudies - most of this code is a copy of the code in get_term_table_content(self): -- duplication in code is bad, so is it possible to extract a helper function here to get the content? e.g. something like _get_term_table_content(self, rows) or similar, and then both methods could call that.
There was a problem hiding this comment.
Hi @jzohrab, sorry for the inconvenience! I totally see your point. I can get this done but not right away (I am on vacation and not sure when I will have time until August 16th or so.) I will tackle it then if there is no rush. :)
2 participants
Referring to this issue: #4
Added four new acceptance tests aimed at addressing the following:
These are done through modifications to the existing book and term feature files as well as a new mgmt feature file (I wasn't sure where else to put the language and backup ones) as well as modifications to conftest.py and lute_test_client.py.
inv all passes.