Improve test assertions and fix docstring#22
Merged
Conversation
- Replace weak len() assertions with exact value checks in TestIneqConstraints - Fix misleading docstring in test_short_time Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ickaser
reviewed
Mar 28, 2026
| Missing coverage: lines 167-172 in functions.py | ||
| """ | ||
| # Test case 1: Normal case | ||
| # Test case 1: Normal case -- both constraints satisfied |
Member
There was a problem hiding this comment.
Did this get modified in a concurrent PR?
Member
|
Seems alright I think, just letting tests run before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
len()assertions with exact value checks inTestIneqConstraintstest_short_timeTest plan
🤖 Generated with Claude Code