Fixed timer issues which arose when premature exit happens#27
Open
abviv wants to merge 1 commit intoLytixDev:mainfrom
Open
Fixed timer issues which arose when premature exit happens#27abviv wants to merge 1 commit intoLytixDev:mainfrom
abviv wants to merge 1 commit intoLytixDev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typically, the log file contains the
$SESSIONwhich inherits the values which gets passed as the CLI args rather than the elapsed session value during the progress of the timer. This merge fixes it and uses the elapsed session by keeping a count of it.GPT summary of the commit:
This pull request includes changes to the
tomatoshellscript to improve logging and session tracking. The key updates involve adding new variables to track completed sessions and actual time spent, and modifying the logging and countdown functions accordingly.Improvements to session tracking and logging:
tomatoshell: AddedCOMPLETED_SESSIONSandACTUAL_TIMEvariables to track the number of completed sessions and the total actual time spent.tomatoshell: Updated thewrite_to_logfunction to logCOMPLETED_SESSIONSand convertACTUAL_TIMEback to minutes for accurate logging.tomatoshell: Modified thecountdownfunction to incrementCOMPLETED_SESSIONSandACTUAL_TIMEafter each work session and store the initial time value for accurate tracking.