clean up some deployment issues, configure repo setup with uv#7
Open
clean up some deployment issues, configure repo setup with uv#7
Conversation
hrodmn
commented
Mar 3, 2025
jjfrench
reviewed
Mar 3, 2025
jjfrench
reviewed
Mar 3, 2025
jjfrench
approved these changes
Mar 3, 2025
Member
jjfrench
left a comment
jjfrench
left a comment
There was a problem hiding this comment.
Thanks for fixing that! I hadn't deployed to see if the changes actually worked
hrodmn
commented
Mar 4, 2025
Comment on lines
+223
to
+225
| "kms:PutKeyPolicy", | ||
| "kms:ScheduleKeyDeletion", | ||
| "kms:CancelKeyDeletion", |
Contributor
Author
There was a problem hiding this comment.
I tried deploying from the branch and I got this error:
❌ MAAP-STAC-auth-dev failed: _ToolkitError: The stack named MAAP-STAC-auth-dev failed to deploy: UPDATE_ROLLBACK_COMPLETE: Resource handler returned message: "The new key policy will not allow you to update the key policy in the future. (Service: Kms, Status Code: 400, Request ID: f6255fc1-e20c-4c38-962b-a9b0ed722e7e)" (RequestToken: 6b4aefbd-8c0e-cdb3-cab7-aa8fc18f2793, HandlerErrorCode: InvalidRequest)so I added a few more permissions.
Contributor
Author
There was a problem hiding this comment.
@jjfrench have we deployed the custom KMS key yet? There seems to be some more that we need to sort out with that configuration so I am going to temporarily turn that feature off in this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to deploy this stack because we were creating/exporting the kms key twice. I also added a pyproject.toml and pre-commit.
resolves #6