Add new spatial bed roughness variable for reg. Coulomb friction#129
Closed
matthewhoffman wants to merge 2 commits into
Closed
Add new spatial bed roughness variable for reg. Coulomb friction#129matthewhoffman wants to merge 2 commits into
matthewhoffman wants to merge 2 commits into
Conversation
This commit adds a new edRoughnessRC variable to MALI on the MPAS side. Corresponding changes are needed on the Albany side.
matthewhoffman
added
the
Albany
matthewhoffman
commented
Dec 17, 2024
| void importFields(std::vector<std::pair<int, int> >& marineBdyExtensionMap, | ||
| double const* bedTopography_F, double const* lowerSurface_F, double const* thickness_F, | ||
| double const* beta_F = 0, double const* stiffnessFactor_F = 0, double const* effecPress_F = 0, double const* muFriction_F = 0, double const* temperature_F = 0, double const* smb_F = 0, double eps = 0); | ||
| double const* beta_F = 0, double const* stiffnessFactor_F = 0, double const* effecPress_F = 0, double const* muFriction_F = 0, double const* bedRoughness_F = 0, double const* temperature_F = 0, double const* smb_F = 0, double eps = 0); |
Author
There was a problem hiding this comment.
@mperego , is this change needed to match the variable name in the calling signature in the cpp file?
Suggested change
| double const* beta_F = 0, double const* stiffnessFactor_F = 0, double const* effecPress_F = 0, double const* muFriction_F = 0, double const* bedRoughness_F = 0, double const* temperature_F = 0, double const* smb_F = 0, double eps = 0); | |
| double const* beta_F = 0, double const* stiffnessFactor_F = 0, double const* effecPress_F = 0, double const* muFriction_F = 0, double const* bedRoughnessRC_F = 0, double const* temperature_F = 0, double const* smb_F = 0, double eps = 0); |
There was a problem hiding this comment.
It's not needed because what matters to the compiler is the position and type of the parameter, but I think it's easier for debugging purposes to use the same names in the function declaration and definition.
Author
|
Closing because these commits are now part of #135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge adds a new edRoughnessRC variable to MALI on the MPAS side. Corresponding changes are needed on the Albany side.