Open
Conversation
Implement a global registry for storing and retrieving site schemas, with support for automatic URL-based schema detection. Registry functions: - register_schema(): Add schema to registry - unregister_schema(): Remove schema from registry - get_schema(): Retrieve schema by name - detect_schema(): Auto-detect schema from URL pattern - list_schemas(): List all registered schema names - get_all_schemas(): Get all schemas as dict - clear_registry(): Clear all schemas (for testing) - is_registered(): Check if schema exists - schema_count(): Count registered schemas - @Schema decorator: Register class or instance Features: - Duplicate name detection with optional overwrite - Type validation for registration - Sorted listing of schema names - First-match-wins auto-detection Includes 35 comprehensive tests. Closes #12
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement a global registry for storing and retrieving site schemas, with support for automatic URL-based schema detection. This builds on #11 (SiteSchema base class).
Changes
New Files
fetcharoo/schemas/registry.py- Registry implementationtests/test_schemas_registry.py- 35 comprehensive testsUpdated Files
fetcharoo/schemas/__init__.py- Export registry functionsRegistry API
Functions
register_schema(schema, overwrite=False)unregister_schema(name)get_schema(name)detect_schema(url)list_schemas()get_all_schemas()clear_registry()is_registered(name)schema_count()@schemaTest Plan
Next Steps
This PR enables:
schemaparameter)Closes
Closes #12