Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion pkg/math/voteweighted/math_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ func (s *MathTestSuite) TestMedian() {
validators []validator
totalBondedTokens sdkmath.Int
expectedPrices map[connecttypes.CurrencyPair]*big.Int
expectedCcvPrices map[connecttypes.CurrencyPair]*big.Int
}{
{
name: "no providers",
Expand Down Expand Up @@ -278,6 +279,31 @@ func (s *MathTestSuite) TestMedian() {
}: big.NewInt(300),
},
},
{
name: "totalBondedTokens is zero",
providerPrices: aggregator.AggregatedProviderData[string, map[connecttypes.CurrencyPair]*big.Int]{
validator1.String(): map[connecttypes.CurrencyPair]*big.Int{
{
Base: "BTC",
Quote: "USD",
}: big.NewInt(100),
},
},
validators: []validator{
{
stake: sdkmath.NewInt(100),
consAddr: validator1,
},
},
totalBondedTokens: sdkmath.NewInt(0),
expectedPrices: map[connecttypes.CurrencyPair]*big.Int{},
expectedCcvPrices: map[connecttypes.CurrencyPair]*big.Int{
{
Base: "BTC",
Quote: "USD",
}: big.NewInt(100),
},
},
}

for _, tc := range cases {
Expand All @@ -295,9 +321,16 @@ func (s *MathTestSuite) TestMedian() {

// Verify the results.
s.Require().Len(defaultResult, len(tc.expectedPrices))
s.Require().Len(ccvResult, len(tc.expectedPrices))
for currencyPair, expectedPrice := range tc.expectedPrices {
s.Require().Equal(expectedPrice, defaultResult[currencyPair])
}

expectedCcvPrices := tc.expectedPrices
if tc.expectedCcvPrices != nil {
expectedCcvPrices = tc.expectedCcvPrices
}
s.Require().Len(ccvResult, len(expectedCcvPrices))
for currencyPair, expectedPrice := range expectedCcvPrices {
s.Require().Equal(expectedPrice, ccvResult[currencyPair])
}
})
Expand Down
7 changes: 7 additions & 0 deletions pkg/math/voteweighted/voteweighted.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,13 @@ func Median(
// This should never error.
panic(err)
}
if totalBondedTokens.IsZero() {
logger.Warn(
"total bonded tokens is zero; cannot compute median prices",
"total_bonded_tokens", totalBondedTokens.String(),
)
return prices
}

for currencyPair, info := range priceInfo {
// The total voting power % that submitted a price update for the given currency pair must be
Expand Down
Loading