Skip to content

Problem: global mutable state in balance handler#12

Closed
yihuang wants to merge 1 commit intoMANTRA-Chain:mantra/v0.4.x_mainfrom
yihuang:balanceHandlerFactory-mantra
Closed

Problem: global mutable state in balance handler#12
yihuang wants to merge 1 commit intoMANTRA-Chain:mantra/v0.4.x_mainfrom
yihuang:balanceHandlerFactory-mantra

Conversation

@yihuang
Copy link
Copy Markdown

@yihuang yihuang commented Oct 9, 2025

balance handler instance in static precompile is a globally mutable state, which has multiple issues with recursive calls or concurrent queries.

Solution:

  • use local balance handler instance

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Solution:
- use local balance handler instance
@yihuang yihuang requested review from freeelancer and mmsqe October 9, 2025 07:13
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants