Skip to content

102502010 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whatword wants to merge 4 commits into
base: homework
Choose a base branch
from
Open

102502010 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4696fa9
Update the slides link
snowmantw Sep 30, 2015
e9a8675
Fix typo
snowmantw Oct 1, 2015
52cd1ff
Merge remote-tracking branch 'refs/remotes/origin/homework'
whatword Oct 23, 2015
efbbe42
V1
whatword Oct 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# The slides

[Follow this link](https://docs.google.com/presentation/d/1ofgD63SENpiihJ_MIYyZVW2TM11Mo-qwcstDbZytqIo/edit?usp=sharing)
53 changes: 33 additions & 20 deletions homework/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@
'use strict';

(function() {
var _wrapper = document.querySelector('#note-content-wrapper');

function start() {
window.addEventListener('note-open', function(event) {
var note = event.detail;
resetWrapper();
drawNote(note);
});
}
(function(exports) {

function resetWrapper() {
_wrapper.innerHTML = '';
}
var NotecontentManager = function() {
this._wrapper = null;
}

NotecontentManager.prototype = {

resetWrapper() {
this._wrapper.innerHTML = '';
},

function drawNote(note) {
drawNote(note) {
var title = note.title;
var h = document.createElement('h2');
h.textContent = title;
Expand All @@ -27,11 +24,27 @@
p.textContent = passage;
buff.appendChild(p);
});
_wrapper.appendChild(h);
_wrapper.appendChild(buff);
this._wrapper.appendChild(h);
this._wrapper.appendChild(buff);
},

handleEvent(event) {
switch(event.type) {
case 'note-open':
var note = event.detail;
this.resetWrapper();
this.drawNote(note);
break;
}
},

start() {
this._wrapper = document.querySelector('#note-content-wrapper');
window.addEventListener('note-open', this);
Copy link
Contributor

@snowmantw snowmantw Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. It's always better to bind the this as event listener rather than an anonymous function.

}

document.addEventListener('DOMContentLoaded', function(event) {
start();
});
})();
};


exports.NotecontentManager = NotecontentManager;
})(window);
1 change: 1 addition & 0 deletions homework/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="UTF-8">
<title> Homework - Note List </title>
<script defer src="main.js"></script>
<script defer src="list.js"></script>
<script defer src="content.js"></script>
<link rel="stylesheet" type="text/css" href="main.css" />
Expand Down
113 changes: 62 additions & 51 deletions homework/list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,44 +1,35 @@
'use strict';

(function() {
(function(exports) {

var _listNoteContent = [];
var _wrapper = document.querySelector('#note-list-wrapper');
var NoteListManager = function() {
this._listNoteContent = [];
this._wrapper = null;
};

function start() {
fetchList(function(data) {
updateList(data);
drawList();
preloadFirstNote();
});
window.addEventListener('click', function(event) {
onNoteOpen(event);
});
}
NoteListManager.prototype = {

function onNoteOpen(event) {
if (event.target.classList.contains('note-title')) {
var id = event.target.dataset.noteId;
var content = _listNoteContent[id];
window.dispatchEvent(new CustomEvent('note-open',
{ detail: content }));
};
}
onNoteOpen(event) {
Copy link
Contributor

@snowmantw snowmantw Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a convention to prefix on to an event handler with the corresponding event. So this method should be renamed as onNoteClicked in fact.

var id = event.target.dataset.noteId;
var content = this._listNoteContent[id];
window.dispatchEvent(new CustomEvent('note-open',
{ detail: content }));
},

function preloadFirstNote() {
if (_listNoteContent.length !== 0) {
var content = _listNoteContent[0];
preloadFirstNote() {
if (this._listNoteContent.length !== 0) {
Copy link
Contributor

@snowmantw snowmantw Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a function body is wrapped by a conditional statement only with one branch, it's better to put the if...else in the caller, rather than the callee.

var content = this._listNoteContent[0];
window.dispatchEvent(new CustomEvent('note-open',
{ detail: content }));
}
}
},

function updateList(list) {
_listNoteContent = list;
}
updateList(list) {
this._listNoteContent = list;
},

function drawList() {
var list = _listNoteContent;
drawList() {
var list = this._listNoteContent;
var ul = document.createElement('ul');
ul.id = 'note-title-list';
var buff = document.createDocumentFragment();
Expand All @@ -52,28 +43,48 @@
buff.appendChild(li);
});
ul.appendChild(buff);
_wrapper.appendChild(ul);
}
this._wrapper.appendChild(ul);
},

function fetchList(afterFetch) {
var xhr = new XMLHttpRequest();
xhr.open('GET', 'http://127.0.0.1:8000/demo-list-notes.json', true);
xhr.responseType = 'json';
xhr.onreadystatechange = function(e) {
// Watch out: we have a mysterious unknown 'this'.
if (this.readyState === 4 && this.status === 200) {
var listData = this.response;
// The flow ends here.
afterFetch(listData);
} else if (this.status !== 200 ){
fetchList() {
return new Promise((function(resolve,reject) {
Copy link
Contributor

@snowmantw snowmantw Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. You have successfully "Promisified" it.

var xhr = new XMLHttpRequest();
xhr.open('GET', 'demo-list-notes.json', true);
xhr.responseType = 'json';
xhr.onreadystatechange = function(e) {
// Watch out: we have a mysterious unknown 'this'.
if (this.readyState === 4 && this.status === 200) {
var listData = this.response;
// The flow ends here.
resolve(listData);
} else if (this.status !== 200 ){
// Ignore error in this case.
}
};
xhr.send();
}
}
};
xhr.send();
}).bind(this));
},

document.addEventListener('DOMContentLoaded', function(event) {
start();
});
handleEvent(event) {
switch(event.type) {
case 'click':
if(event.target.classList.contains('note-title')) {
this.onNoteOpen(event);
}
break;
}
},

start() {
window.addEventListener('click',this);
this._wrapper = document.querySelector('#note-list-wrapper');
this.fetchList().then((function(data) {
Copy link
Contributor

@snowmantw snowmantw Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I would recommend to use Arrow function instead of the bind API. It's more concise.

Copy link
Contributor

@snowmantw snowmantw Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another point is in this way you didn't practice how to chain a Promise. So although it's unnecessary, please try to make a chain with several then and a catch.

this.updateList(data);
this.drawList();
this.preloadFirstNote();
}).bind(this));
}
};

})();
exports.NoteListManager = NoteListManager;
})(window);
9 changes: 9 additions & 0 deletions homework/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';

// Kick off
document.addEventListener('DOMContentLoaded', function(event) {
var todoListManager = new NoteListManager();
var todocontentManager = new NotecontentManager();
todoListManager.start();
todocontentManager.start();
});
14 changes: 10 additions & 4 deletions homework/test/test-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
describe('Test > ', function() {
beforeEach(function() {
});
describe('Test NoteListManager', function() {
var subject;

beforeEach(function() {
subject = new NoteListManager();
});

it('will test some pure functions', function() {
it('It will test drawList functions', function() {
// Write any pure function assertion here.
subject._wrapper = document.createElement('div');
subject.drawList([]);
assert.isNull(subject._wrapper.querySelector('li'));
Copy link
Contributor

@snowmantw snowmantw Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. You tested a real method instead of a mocked one.

});
});