Skip to content

tools: better hlil and mlil. add comments and identation #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cybergrind wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tools: better hlil and mlil. add comments and identation #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cedd06
tools: better high_level_il. add comments and identation
cybergrind Apr 14, 2025
8f20afd
tools: better medium_level_il. add comments and formatting
cybergrind Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions src/binaryninja_mcp/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ def high_level_il(self, address_or_name: str) -> str:
func = self.bv.get_function_at(addr)
if not func:
raise ValueError(f'No function found at address {hex(addr)}')
comments = func.comments

# Get HLIL
hlil = func.hlil
Expand All @@ -195,10 +196,17 @@ def high_level_il(self, address_or_name: str) -> str:

# Format the HLIL output
lines = []
for instruction in hlil.instructions:
lines.append(f'{instruction.address:#x}: {instruction}\n')
if func.comment:
lines.append(f'{func.start:#x}: // {func.comment}')
lines.append(f'{func.start:#x}: {func}')

return ''.join(lines)
for line in hlil.root.lines:
if line.address in comments:
lines.append(f'{line.address:#x}: {line} // {comments[line.address]}')
else:
lines.append(f'{line.address:#x}: {line}')

return '\n'.join(lines)

@handle_exceptions
def medium_level_il(self, address_or_name: str) -> str:
Expand All @@ -217,6 +225,7 @@ def medium_level_il(self, address_or_name: str) -> str:
func = self.bv.get_function_at(addr)
if not func:
raise ValueError(f'No function found at address {hex(addr)}')
comments = func.comments

# Get MLIL
mlil = func.mlil
Expand All @@ -225,10 +234,20 @@ def medium_level_il(self, address_or_name: str) -> str:

# Format the MLIL output
lines = []
if func.comment:
lines.append(f'{func.start:#x}: // {func.comment}')
lines.append(f'{func.start:#x}: {func}')

# MLIL doesn't have a root property like HLIL, so we iterate through instructions directly
for instruction in mlil.instructions:
lines.append(f'{instruction.address:#x}: {instruction}\n')
if instruction.address in comments:
lines.append(
f'{instruction.address:#x}: {instruction} // {comments[instruction.address]}'
)
else:
lines.append(f'{instruction.address:#x}: {instruction}')

return ''.join(lines)
return '\n'.join(lines)

@handle_exceptions
def disassembly(self, address_or_name: str, length: Optional[int] = None) -> str:
Expand Down