added equi-depth SAX breakpoints for all approaches. Gaussian by defa… - #64
Merged
Conversation
…ult (for z-norm data)
MChatzakis
requested changes
Jul 25, 2026
MChatzakis
left a comment
MChatzakis
left a comment
Owner
There was a problem hiding this comment.
General comment:
This SAX breakpoint issue for non z-normed data is related to iSAX-based algos (MESSI, FreSH, Odyssey, Paris, SING).
What happens for other algos (e.g., SOFA/Hercules)? Do they support non-z-normed data? If not, we should extend this pr to fix them as well.
PTAL at the "activeBP" function which is called inside the search functions, I left a comment for that, this worries me a little bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataset depended SAX breakpoints for non z-normalized data.